linux-kernel - [PATCH v4] clk: Show correct information when fail to set clock rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1430126992-26905-1-git-send-email-cw00.choi@samsung.com>
Date:	Mon, 27 Apr 2015 18:29:52 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	mturquette@...aro.org, sboyd@...eaurora.org, s.nawrocki@...sung.com
Cc:	linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>
Subject: [PATCH v4] clk: Show correct information when fail to set clock rate

This patch shows the correct information for debugging when fail to set clock
rate because original error message shows the error value instead of current
clock rate.

Cc: Mike Turquette <mturquette@...aro.org>
Cc: Stephen Boyd <sboyd@...eaurora.org>
Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
---
Changes from v3:
- Show the correct information (clock rate, error value, current clock rate
  after fail to set clock rate)
Changes from v2:
- Show the current clock rate when fail to set clock rate
Changes from v1:
- Add error value of clk_set_rate() with current clock rate

 drivers/clk/clk-conf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
index 48a65b2..000692b 100644
--- a/drivers/clk/clk-conf.c
+++ b/drivers/clk/clk-conf.c
@@ -106,8 +106,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
 
 			rc = clk_set_rate(clk, rate);
 			if (rc < 0)
-				pr_err("clk: couldn't set %s clock rate: %d\n",
-				       __clk_get_name(clk), rc);
+				pr_err("clk: couldn't set %s clk rate to %d (%d), current rate: %ld\n",
+				       __clk_get_name(clk), rate, rc, clk_get_rate(clk));
 			clk_put(clk);
 		}
 		index++;
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/