linux-kernel - Re: [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Apr 2015 13:40:19 +0100
From:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	lee.jones@...aro.org, linus.walleij@...aro.org, gnurou@...il.com,
	myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	ckeepax@...nsource.wolfsonmicro.com,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814

On Wed, Apr 22, 2015 at 12:08:08PM +0100, Mark Brown wrote:
> On Tue, Apr 21, 2015 at 01:33:51PM +0100, Richard Fitzgerald wrote:
> 
> > +	switch (arizona->type) {
> > +	case WM8998:
> > +	case WM1814:
> > +		/* Some bits are shifted on WM8998,
> > +		 * rearrange to match the standard bit layout
> > +		 */
> > +		val[0] = ((val[0] & 0x60e0) >> 1) |
> > +			 ((val[0] & 0x1e00) >> 2) |
> > +			 (val[0] & 0x000f);
> > +		break;
> 
> Are you sure this approach is going to scale (and avoid confusion)?

It's a total one-off for the WM8998/WM1814, no other codecs have
this shifted-bit-position problem. This shouldn't happen for any
future codecs, so I don't feel like it's worth over-complicating it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/