linux-kernel - Re: [PATCH 1/1] Documentation: Add dt-binding for TI-btwilink driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AE3797AF-6797-44E0-828C-6498DB73980F@holtmann.org>
Date:	Sun, 26 Apr 2015 21:31:58 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Gigi Joseph <gigi.joseph@...il.com>
Cc:	devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org, Gigi Joseph <gigi.joseph@...com>
Subject: Re: [PATCH 1/1] Documentation: Add dt-binding for TI-btwilink driver

Hi Gigi,

> btwilink binds bluetooth hci0 interface with the shared transport driver
> 
> Signed-off-by: Gigi Joseph <gigi.joseph@...com>
> ---
> Documentation/devicetree/bindings/btwilink.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/btwilink.txt
> 
> diff --git a/Documentation/devicetree/bindings/btwilink.txt b/Documentation/devicetree/bindings/btwilink.txt
> new file mode 100644
> index 0000000..d286aea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/btwilink.txt
> @@ -0,0 +1,15 @@
> +btwilink
> +--------
> +
> +Required properties:
> +
> +	- compatible : must be "ti,btwilink"
> +
> +Example:
> +
> +Enable the btwilink driver to bind the bluetooth hci0 interface with
> +ti-st shared transport driver
> +
> +btwilink {
> +	compatible = "ti,btwilink";
> +};

actually I wonder if someone finally starts re-writing the TI-ST driver to integrate with the new Bluetooth subsystem features (like hdev->setup, __hci_cmd_sync and h4_recv_buf) so that this complicated setup is no longer needed.

I do not think we actually would need a shared transport at all. We should have a Bluetooth HCI driver that can have children for FM radio and GPS exposed. Exposing proper platform devices with Bluetooth HCI as parent makes sense. The shared transport is not really a parent. First and foremost, this is a Bluetooth chip. The FM radio and GPS features are just glued on top of it.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/