linux-kernel - Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5Dg9FkGkSS7mygv3OdfdF4jOK_nbTvx8eUTGD+EMmRs0g@mail.gmail.com>
Date:	Mon, 27 Apr 2015 14:59:39 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Niklas Cassel <niklas.cassel@...s.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, johan@...nel.org,
	Niklas Cassel <niklass@...s.com>
Subject: Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK

On Mon, Apr 27, 2015 at 8:00 AM, Niklas Cassel <niklas.cassel@...s.com> wrote:

> Since NULL is a valid clock, we shouldn't use
> IS_ERR_OR_NULL.

Yes, but this code is not using IS_ERR_OR_NULL.

It seems that you are not describing the problem you are trying to solve.

What is the exact issue you are seeing?

>         clk = devm_clk_get(&phydev->dev, "rmii-ref");

You need to provide the 'rmii-ref' in your board file or dts.

Are you doing this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/