linux-kernel - Re: [PATCH 2/2] livepatch: x86: make kASLR logic more accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLU436-SMTP2437B2E3BC3EAEBF1FCADA294E80@phx.gbl>
Date:	Tue, 28 Apr 2015 08:08:00 +0800
From:	Minfei Huang <minfei.huang@...mail.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	x86@...nel.org, Borislav Petkov <bp@...en8.de>,
	Kees Cook <keescook@...omium.org>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Vojtech Pavlik <vojtech@...e.cz>, linux-kernel@...r.kernel.org,
	live-patching@...r.kernel.org
Subject: Re: [PATCH 2/2] livepatch: x86: make kASLR logic more accurate

On 04/28/15 at 01:29P, Jiri Kosina wrote:
> On Mon, 27 Apr 2015, Minfei Huang wrote:
> 
> > Found that kaslr_enabled is only exist for x86. Maybe you can define a 
> > weak function klp_adjustment_function_addr in general. Then each arch 
> > can overwrite the function to implemente it specially.
> 
> It might start to make sense once there is at least one additional arch 
> that supports kaslr. Currently, I don't see a benefit.
> 
> Why are you so obstinate about this? I personally don't find that 
> important at all; it's something that can always be sorted out once more 
> archs start supporting kaslr.
> 

ohhh... Previously, IMO, putting the relevant function address adjustment
into the specified arch is more clearly to be reviewed and understood.

Now, I know what you actual want according to above commit, I am fine
with it.

Thanks
Minfei

> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/