linux-kernel - Re: [PATCH v3 1/3] mfd: provide RTC resource in MT6397 MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150428074554.GZ19431@pengutronix.de>
Date:	Tue, 28 Apr 2015 09:45:54 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Eddie Huang <eddie.huang@...iatek.com>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tomasz Figa <tfiga@...gle.com>,
	Uwe Kleine-König <kernel@...gutronix.de>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	rtc-linux@...glegroups.com, Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, srv_heupstream@...iatek.com,
	linux-mediatek@...ts.infradead.org, Joe Perches <joe@...ches.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/3] mfd: provide RTC resource in MT6397 MFD

Hello,

On Tue, Apr 28, 2015 at 03:35:54PM +0800, Eddie Huang wrote:
> Provide MT6397 RTC interrupt, base address, and register in
> MT6397 MFD.
> 
> Signed-off-by: Eddie Huang <eddie.huang@...iatek.com>
> ---
>  drivers/mfd/mt6397-core.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..08cfbd1 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -21,9 +21,27 @@
>  #include <linux/mfd/mt6397/core.h>
>  #include <linux/mfd/mt6397/registers.h>
>  
> +#define MT6397_RTC_BASE		0xe000
> +#define MT6397_RTC_SIZE		0x3e
> +
> +static const struct resource mt6397_rtc_resources[] = {
> +	{
> +		.start = MT6397_RTC_BASE,
> +		.end   = MT6397_RTC_BASE + MT6397_RTC_SIZE,
> +		.flags  = IORESOURCE_MEM,
It's definitly a matter of taste if you align the rhs here, but if you
do, do it consitently. That is, either make sure that all equal signs
are in a single column (at least per struct resource), or use a single
space between variable name and =.

If you want to hear my personal preference: I always use a single space.
As if you have to add
	.somelongvariablename = somevalue

you have to touch all other lines, too, which is ugly.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/