linux-kernel - Re: [PATCH v3] ARM: tegra: Correct which USB controller has the UTMI pad registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <553F4EA9.4000307@gmail.com>
Date:	Tue, 28 Apr 2015 10:11:05 +0100
From:	Jon Hunter <jgchunter@...il.com>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	linux-tegra@...r.kernel.org
CC:	Mark Rutland <mark.rutland@....com>,
	Alexandre Courbot <gnurou@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-kernel@...r.kernel.org,
	Mikko Perttunen <mikko.perttunen@...si.fi>,
	devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Tuomas Tynkkynen <ttynkkynen@...dia.com>,
	Kumar Gala <galak@...eaurora.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] ARM: tegra: Correct which USB controller has the UTMI
 pad registers


On 04/03/2015 08:21 AM, Tomeu Vizoso wrote:
> It should be the first controller, not the second. The indexes of the
> usb resets were also wrong and have been fixed.
> 
> The issue was caused by the changes in 308efde ("ARM: tegra: Add resets
> & has-utmi-pad-registers flag to all USB PHYs") being misapplied by git
> due to the patch context being insufficient.
> 
> This broke USB after 6261b06 ("regulator: Defer lookup of supply to
> regulator_get"), because it changed the order in which the controllers
> were probed.
> 
> The fix for this issue was suggested by Mikko Perttunen and Tuomas
> Tynkkynen.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> Cc: Mikko Perttunen <mikko.perttunen@...si.fi>
> Cc: Tuomas Tynkkynen <ttynkkynen@...dia.com>
> ---
> Hi,
> 
> hope I have gotten it right this time, but please do check :)

FWIW, this works for me.

Tested-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/