linux-kernel - Re: [PATCH 11/13] mm: meminit: Free pages in large chunks where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150428113819.GL2449@suse.de>
Date:	Tue, 28 Apr 2015 12:38:20 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linux-MM <linux-mm@...ck.org>, Nathan Zimmer <nzimmer@....com>,
	Dave Hansen <dave.hansen@...el.com>,
	Waiman Long <waiman.long@...com>,
	Scott Norton <scott.norton@...com>,
	Daniel J Blueman <daniel@...ascale.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 11/13] mm: meminit: Free pages in large chunks where
 possible

On Mon, Apr 27, 2015 at 03:43:56PM -0700, Andrew Morton wrote:
> On Thu, 23 Apr 2015 11:33:14 +0100 Mel Gorman <mgorman@...e.de> wrote:
> 
> > Parallel struct page frees pages one at a time. Try free pages as single
> > large pages where possible.
> > 
> > ...
> >
> >  void __defermem_init deferred_init_memmap(int nid)
> 
> This function is gruesome in an 80-col display.  Even the code comments
> wrap, which is nuts.  Maybe hoist the contents of the outermost loop
> into a separate function, called for each zone?

I can do better than that because only the highest zone is deferred
in this version and the loop is no longer necessary. I should post a V4
before the end of my day that addresses your feedback.  It caused a lot of
conflicts and it'll be easier to replace the full series than try managing
incremental fixes.

Thanks Andrew.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/