[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdYKmq3giv_Wyy+94puHpxaNxgooQFEtwhv-sH0sMK739g@mail.gmail.com>
Date: Tue, 28 Apr 2015 14:23:43 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: "Ivan T. Ivanov" <iivanov@...sol.com>
Cc: Mathieu Poirier <mathieu.poirier@...aro.org>,
Greg KH <gregkh@...uxfoundation.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Kaixu Xia <kaixu.xia@...aro.org>,
Chunyan Zhang <zhang.chunyan@...aro.org>
Subject: Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver
On Fri, Apr 24, 2015 at 5:41 PM, Ivan T. Ivanov <iivanov@...sol.com> wrote:
> On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote:
>>
>
>> +static struct amba_id etm4_ids[] = {
>> + { /* ETM 4.0 - Hi6220 board */
>> + .id = 0x0003b95d,
>> + .mask = 0x0003ffff,
>> + .data = "ETM 4.0",
>> + },
>> + { /* ETM 4.0 - Juno board */
>> + .id = 0x000bb95e,
>> + .mask = 0x000bffff,
>
> Mask looks suspicious.
I'm thinking that maybe we should have some masks predefined in
<linux/amba/bus.h> for bits in this field so we get it right.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists