linux-kernel - Re: [PATCH] usb: gadget: composite: enable BESL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150428154501.GA18263@saruman.tx.rr.com>
Date:	Tue, 28 Apr 2015 10:45:01 -0500
From:	Felipe Balbi <balbi@...com>
To:	"Du, Changbin" <changbin.du@...el.com>
CC:	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Cohen, David A" <david.a.cohen@...el.com>,
	"Wu, Hao" <hao.wu@...el.com>
Subject: Re: [PATCH] usb: gadget: composite: enable BESL support

On Tue, Apr 28, 2015 at 07:56:13AM +0000, Du, Changbin wrote:
> From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001
> From: Felipe Balbi <balbi@...com>
> Date: Tue, 30 Sep 2014 16:08:03 -0500
> Subject: [PATCH] usb: gadget: composite: enable BESL support

missing upstream commit.

> According to USB 2.0 ECN Errata for Link Power
> Management (USB2-LPM-Errata-final.pdf), BESL
> must be enabled if LPM is enabled.
> 
> This helps with USB30CV TD 9.21 LPM L1
> Suspend Resume Test.
> 
> Cc: <stable@...r.kernel.org> # 3.14

this should be backported all the way back to 3.1. The commit which this
patch is fixing, was applied on v3.1, so we're probably going to
backport to 3.10 and 3.14. When asking for backports, don't consider
only your project, think about the kernel/stable releases as a whole.

BTW, that should be v3.1+, the + tells the Stable team that from v3.1
forward, all kernels need the backport.

> Signed-off-by: Felipe Balbi <balbi@...com>
> Signed-off-by: Du, Changbin <changbin.du@...el.com>
> ---
> Hi,
> 
> This patch was introduced on v3.18. However the issue fixed already existed on
> v3.14 and v3.14 is a long term support version.

the issue already existed on v3.1, why did you decide to backport only
to v3.14 ?

> So propose to backport it over there as well.
> 
> Du, Changbin
> ---
>  drivers/usb/gadget/composite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index a8c18df..f6a51fd 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev)
>  	usb_ext->bLength = USB_DT_USB_EXT_CAP_SIZE;
>  	usb_ext->bDescriptorType = USB_DT_DEVICE_CAPABILITY;
>  	usb_ext->bDevCapabilityType = USB_CAP_TYPE_EXT;
> -	usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT);
> +	usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPORT);
>  
>  	/*
>  	 * The Superspeed USB Capability descriptor shall be implemented by all

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)