linux-kernel - Re: [PATCH 0/2] ACPI: Translate Linux IRQ number directly from GpioInt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <553FC530.1020305@linux.intel.com>
Date:	Tue, 28 Apr 2015 10:36:48 -0700
From:	sathyanarayanan kuppuswamy 
	<sathyanarayanan.kuppuswamy@...ux.intel.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Octavian Purdila <octavian.purdila@...el.com>,
	Robert Dolca <robert.dolca@...el.com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 0/2] ACPI: Translate Linux IRQ number directly from GpioInt



On 04/28/2015 08:05 AM, Mika Westerberg wrote:
> Hi,
>
> Currently drivers for ACPI enumerated devices that have their interrupt
> line connected to a GPIO controller instead of IO-APIC are required to do
> complete gpiod_get()/gpiod_to_irq() etc. dance themselves. This adds
> unnecessary lines of code to these drivers.
>
> It turned out that DT solved the problem already with introduction of
> of_irq_get() which is able to handle GPIO based interrupts as well through
> irqchip API [1].
>
> Following two patches does the same for ACPI by introducing new function
> acpi_dev_gpio_irq_get() that is then used in I2C core to automatically
> translate ACPI GpioInt resource to Linux IRQ number.
>
> This requires that the boot firmware (BIOS/coreboot) configures these pins
> correctly (input, etc) before handing over to OS. I've tested this on Intel
> Baytrail, Braswell and Skylake based machines where this is true.
Why not configure the GPIO pin as input in the API itself ?
>
> [1] https://lkml.org/lkml/2015/3/25/103
>
> Mika Westerberg (2):
>    gpio / ACPI: Add support for retrieving GpioInt resources from a device
>    i2c / ACPI: Assign IRQ for devices that have GpioInt automatically
>
>   drivers/gpio/gpiolib-acpi.c | 29 +++++++++++++++++++++++++++++
>   drivers/i2c/i2c-core.c      |  9 +++++++--
>   include/linux/acpi.h        |  7 +++++++
>   3 files changed, 43 insertions(+), 2 deletions(-)
>

-- 
Sathyanarayanan Kuppuswamy
Android kernel developer

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/