linux-kernel - Re: [PATCH] usb: gadget: composite: enable BESL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429055334.GA29821@saruman.tx.rr.com>
Date:	Wed, 29 Apr 2015 00:53:34 -0500
From:	Felipe Balbi <balbi@...com>
To:	"Du, Changbin" <changbin.du@...el.com>
CC:	"balbi@...com" <balbi@...com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Cohen, David A" <david.a.cohen@...el.com>,
	"Wu, Hao" <hao.wu@...el.com>
Subject: Re: [PATCH] usb: gadget: composite: enable BESL support

On Wed, Apr 29, 2015 at 03:04:51AM +0000, Du, Changbin wrote:
> > > From: Felipe Balbi <balbi@...com>
> > > Date: Tue, 30 Sep 2014 16:08:03 -0500
> > > Subject: [PATCH] usb: gadget: composite: enable BESL support
> > 
> > missing upstream commit.
> > 
> > > According to USB 2.0 ECN Errata for Link Power Management
> > > (USB2-LPM-Errata-final.pdf), BESL must be enabled if LPM is enabled.
> > >
> > > This helps with USB30CV TD 9.21 LPM L1 Suspend Resume Test.
> > >
> > > Cc: <stable@...r.kernel.org> # 3.14
> > 
> > this should be backported all the way back to 3.1. The commit which this
> > patch is fixing, was applied on v3.1, so we're probably going to backport to
> > 3.10 and 3.14. When asking for backports, don't consider only your project,
> > think about the kernel/stable releases as a whole.
> > 
> > BTW, that should be v3.1+, the + tells the Stable team that from v3.1 forward,
> > all kernels need the backport.
> > 
> > > Signed-off-by: Felipe Balbi <balbi@...com>
> > > Signed-off-by: Du, Changbin <changbin.du@...el.com>
> > > ---
> > > Hi,
> > >
> > > This patch was introduced on v3.18. However the issue fixed already
> > > existed on
> > > v3.14 and v3.14 is a long term support version.
> > 
> > the issue already existed on v3.1, why did you decide to backport only to
> > v3.14 ?
> > 
> > > So propose to backport it over there as well.
> > >
> > --
> > balbi
> 
> Thanks for pointing it out, Balbi. Sorry for not considering the whole
> trees. This is my first time to send backport request and now know how
> do it well. I will resend request with field updated.

ok, things which usually help are:

'git log -SLPM -- drivers/usb/gadget/composite.c'
	this will help you find commits which have the string LPM in
	their body and touch drivers/usb/gadget/composite.c

'git describe'
	this will tell you when a commit was merged. Keep in mind that a
	commit reaches a maintainer tree before Linus tags something, so
	if git describe says: v3.0-rc3-212-gfoobar, that means commit
	reaches mainline during v3.1 merge window.

Documentation/stable_kernel_rules.txt
	This tells what a stable patch should look like

'git remote add stable \
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git \
	&& git fetch stable && git log stable/linux-3.14.y'

	This would help you see actual commits in a stable tree so you
	can mimic the format.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)