linux-kernel - Re: [PATCH 2/2] visor: Match I330 phone more precisely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150429104322.GB32318@localhost>
Date:	Wed, 29 Apr 2015 12:43:22 +0200
From:	Johan Hovold <johan@...nel.org>
To:	"Jason A. Donenfeld" <Jason@...c4.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH 2/2] visor: Match I330 phone more precisely

On Wed, Apr 22, 2015 at 04:30:12PM +0200, Johan Hovold wrote:
> On Wed, Apr 22, 2015 at 02:35:09PM +0200, Jason A. Donenfeld wrote:
> > Samsung has just released a portable USB3 SSD, coming in a very small
> > and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
> > already used by the Palm Visor driver for the Samsung I330 phone cradle.
> > Having pl2303 or visor pick up this device ID results in conflicts with
> > the usb-storage driver, which handles the newly released portable USB3
> > SSD.
> > 
> > To work around this conflict, I've dug up a mailing list post [1] from a
> > long time ago, in which a user posts the full USB descriptor
> > information. The most specific value in this appears to be the interface
> > class, which has value 255 (0xff). Since usb-storage requires an
> > interface class of 0x8, I believe it's correct to disambiguate the two
> > devices by matching on 0xff inside visor.
> > 
> > [1] http://permalink.gmane.org/gmane.linux.usb.user/4264
> > 
> > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> 
> Both patches look good, but next time remember to include a patch
> revision in the subject of all patches in a series (this would be
> [PATCH v3]). Please use a "USB: " prefix as well.
> 
> I'll fix it up before applying this time.

Both patches now applied with stable tags.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/