linux-kernel - Re: [PATCH RESEND] mfd: arizona: Remove redundant register sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2015 11:55:02 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] mfd: arizona: Remove redundant register sync

On Wed, 22 Apr 2015, Charles Keepax wrote:

> This soft reset used to be located after the register patch had been
> applied, but has since moved to before the patch is applied. At the new
> location there is no requirement to do a register sync as no register
> writes will have happened yet.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 6ca6dfa..aed43a5 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)
>  
>  	/* If we have a /RESET GPIO we'll already be reset */
>  	if (!arizona->pdata.reset) {
> -		regcache_mark_dirty(arizona->regmap);
> -
>  		ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
>  		if (ret != 0) {
>  			dev_err(dev, "Failed to reset device: %d\n", ret);
> @@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona)
>  		}
>  
>  		msleep(1);
> -
> -		ret = regcache_sync(arizona->regmap);
> -		if (ret != 0) {
> -			dev_err(dev, "Failed to sync device: %d\n", ret);
> -			goto err_reset;
> -		}
>  	}
>  
>  	/* Ensure device startup is complete */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/