linux-kernel - RE: [PATCH V1 6/6] devicetree: da9062: Add bindings for DA9062 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B217AE3@SW-EX-MBX02.diasemi.com>
Date:	Wed, 29 Apr 2015 11:26:53 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>,
	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
CC:	DEVICETREE <devicetree@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	LINUXKERNEL <linux-kernel@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	"David Dajun Chen" <david.chen@...semi.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	LINUXINPUT <linux-input@...r.kernel.org>,
	LINUXWATCHDOG <linux-watchdog@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"Mark Brown" <broonie@...nel.org>,
	RTCLINUX <rtc-linux@...glegroups.com>,
	"Samuel Ortiz" <sameo@...ux.intel.com>,
	Support Opensource <Support.Opensource@...semi.com>,
	Wim Van Sebroeck <wim@...ana.be>
Subject: RE: [PATCH V1 6/6] devicetree: da9062: Add bindings for DA9062
 driver

On 29 April 2015 11:54 Lee Jones wrote :

> On Fri, 17 Apr 2015, S Twiss wrote:
> > From: S Twiss <stwiss.opensource@...semi.com>
> >
> > Add device tree bindings for the DA9062 driver
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> >
> > ---
> >
> > This patch applies against linux-next and v4.0
> >
> >  Documentation/devicetree/bindings/mfd/da9062.txt | 107
> +++++++++++++++++++++++
> >  1 file changed, 107 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/da9062.txt
> 
> I don't see anything groundbreaking or offensive.
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>
> 

Thank you for the review and Ack.

I am in the process of updating the DA9063 OnKey driver in a different thread.
This driver is functionally similar to the DA9062 OnKey driver as was discussed in
an earlier thread from DA9063.

http://www.spinics.net/lists/linux-input/msg38137.html

Although the 63 and 62 chips have sequential numbers they are not the same,
however the OnKey driver is functionally very similar and so I am going to try and
merge the code for both drivers in the case of the OnKey.

Due to the DA9063 being currently reviewed, perhaps it would be prudent not
to add this device tree bindings for DA9062 to the kernel just yet -- the device tree
bindings could change for the OnKey in my DA9063 submission and this would affect
the DA9062 driver when I merge the two OnKey drivers.

I will put a full version history in my next patch set to describe what changes I have
made to this file so this review is not deemed a wasted effort.

Regards,
Steve

[...]