linux-kernel - Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429130840.GI24346@pali>
Date:	Wed, 29 Apr 2015 15:08:40 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	Darren Hart <dvhart@...radead.org>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alex Hung <alex.hung@...onical.com>
Subject: Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode
 Switch driver

On Wednesday 29 April 2015 12:30:32 Gabriele Mazzotta wrote:
> On Wednesday 29 April 2015 11:51:04 Pali Rohár wrote:
> > This is an ACPI driver for Dell laptops which receive HW switch events.
> > It exports rfkill device dell-rbtn which provide correct hard rfkill state.
> > 
> > Alex Hung added code for supporting Dell laptops which have toggle button
> > instead HW slider switch. On these laptops toggle button event is reported
> > by new input device (instead rfkill) as they do not have hw radio switch.
> > 
> > It looks like those are two different functions (rfkill, input device), but
> > Dell BIOS exports them via same ACPI device and uses same ACPI functions.
> > So code is in one kernel driver.
> 
> I made a patch some time ago that I've just adapted. It allows to
> prefer RBTN_SLIDER over RBTN_TOGGLE. The main reason why I'd like to
> have the hardware switch is that the BIOS doesn't alter the soft state
> of the devices. This comes in handy when the function key controls
> multiple radio devices.
> 

Now I'm thinking... is't this bug in wifi kernel driver (which exports
phy rfkill)? Or problem somewhere else (userspace or kernel)?

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/