linux-kernel - Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5540EF78.8000409@linux.vnet.ibm.com>
Date:	Wed, 29 Apr 2015 20:19:28 +0530
From:	Shreyas B Prabhu <shreyas@...ux.vnet.ibm.com>
To:	Preeti Murthy <preeti.lkml@...il.com>, rostedt@...dmis.org
CC:	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	aneesh.kumar@...ux.vnet.ibm.com,
	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline
 cpus


>> -DEFINE_EVENT_PRINT(mm_page, mm_page_pcpu_drain,
>> +TRACE_EVENT_CONDITION(mm_page_pcpu_drain,
>>
>>         TP_PROTO(struct page *page, unsigned int order, int migratetype),
>>
>>         TP_ARGS(page, order, migratetype),
>>
>> +       TP_CONDITION(cpu_online(smp_processor_id())),
>> +
>> +       TP_STRUCT__entry(
>> +               __field(        unsigned long,  pfn             )
>> +               __field(        unsigned int,   order           )
>> +               __field(        int,            migratetype     )
>> +       ),
>> +
>> +       TP_fast_assign(
>> +               __entry->pfn            = page ? page_to_pfn(page) : -1UL;
>> +               __entry->order          = order;
>> +               __entry->migratetype    = migratetype;
>> +       ),
>> +
> 
> What was the need to do the above changes besides adding TP_CONDITION ?
> 

IIUC there is no existing macro which can both add a condition and
override printk format, hence the fall back to TRACE_EVENT_CONDITION.

Thanks,
Shreyas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/