linux-kernel - Re: [PATCH V3 05/25] perf tools: Hit all build ids when AUX area tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429152633.GE7822@krava.redhat.com>
Date:	Wed, 29 Apr 2015 17:26:33 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Namhyung Kim <namhyung@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH V3 05/25] perf tools: Hit all build ids when AUX area
 tracing

On Wed, Apr 29, 2015 at 03:24:03PM +0300, Adrian Hunter wrote:
> On 28/04/15 15:45, Jiri Olsa wrote:
> > On Fri, Apr 24, 2015 at 10:29:47PM +0300, Adrian Hunter wrote:
> >> We need to include all buildids when a perf.data
> >> file contains AUX area tracing data because we
> >> do not decode the trace for that purpose because
> >> it would take too long.
> >>
> >> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> >> ---
> >>  tools/perf/builtin-buildid-list.c |  9 +++++++++
> >>  tools/perf/builtin-inject.c       |  8 +++++++-
> >>  tools/perf/builtin-record.c       | 10 +++++++++-
> >>  3 files changed, 25 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c
> >> index feb420f..9fe93c8 100644
> >> --- a/tools/perf/builtin-buildid-list.c
> >> +++ b/tools/perf/builtin-buildid-list.c
> >> @@ -69,6 +69,15 @@ static int perf_session__list_build_ids(bool force, bool with_hits)
> >>  	session = perf_session__new(&file, false, &build_id__mark_dso_hit_ops);
> >>  	if (session == NULL)
> >>  		return -1;
> >> +
> >> +	/*
> >> +	 * We take all buildids when the file contains AUX area tracing data
> >> +	 * because we do not decode the trace because it would take too long.
> >> +	 */
> >> +	if (!perf_data_file__is_pipe(&file) &&
> >> +	    perf_header__has_feat(&session->header, HEADER_AUXTRACE))
> >> +		with_hits = false;
> > 
> > when there's auxtrace in the perf.data, all the dsos would have
> > hits (as per builtin-record.c change below) and be display anyway,
> > so it seems we dont need this hunk?
> 
> When there's auxtrace in the perf.data file, then all dsos would be recorded
> with build ids in the build_id section.
> 
> This hunk causes:
> 	1) no session processing to find hits

ok, missed the perf_session__process_events call in here :-\

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/