linux-kernel - Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mw1q2a8l.fsf@linaro.org>
Date:	Wed, 29 Apr 2015 17:02:50 +0100
From:	Alex Bennée <alex.bennee@...aro.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	mingo@...hat.com, Dave.Martin@....com,
	linux-kernel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
	Javi Merino <javi.merino@....com>,
	"Peter Zijlstra \(Intel\)" <peterz@...radead.org>
Subject: Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len


Steven Rostedt <rostedt@...dmis.org> writes:

> On Wed, 29 Apr 2015 16:18:46 +0100
> Alex Bennée <alex.bennee@...aro.org> wrote:
>
>> The only caller to this function (__print_array) was getting it wrong by
>> passing the array length instead of buffer length. As the element size
>> was already being passed for other reasons it seems reasonable to push
>> the calculation of buffer length into the function.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@...aro.org>
>
> Thanks, I'll add a stable tag to this too, and get it out soon.

I take it you'll pick up Dave's reviewed-by?

As for CC'ing stable I wouldn't worry too much as nothing in the kernel
uses __print_array yet (unless you count the example). But it is a
fairly trivial patch so if you as the maintainer is happy I'm happy ;-)

>
> -- Steve
>
>> 
>> ---
>> v2:
>>   - more explicit commit message
>>   - rename len -> count to reduce ambiguity
>> ---
>>  include/linux/ftrace_event.h | 2 +-
>>  kernel/trace/trace_output.c  | 3 ++-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>> 

-- 
Alex Bennée
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/