linux-kernel - Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7chr1-aRDsHEpr1vApgfYns85FvVaHQc3JmdhHVzscKt_w@mail.gmail.com>
Date:	Thu, 30 Apr 2015 01:11:40 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6

On Thu, Apr 30, 2015 at 1:02 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Thu, Apr 30, 2015 at 12:54:31AM +0900, Namhyung Kim wrote:
>> The YYLTYPE_IS_TRIVIAL is defined in the Build file, but unlike
>> pmu-bison.c, gcc complained about it for parse-events-bison.c:
>
> any clue why is that? cant see why Fedora is not complaining
> over the same sources and RHEL6 fails..

I have no idea.  I just found it during build test using containers,
and had no chance to look into the bison code..

Thanks,
Namhyung


>>
>>     CC       util/parse-events-bison.o
>>   In file included from util/parse-events.y:16:
>>   util/parse-events-bison.h:101:1: error: "YYLTYPE_IS_TRIVIAL" redefined
>>   <command-line>: error: this is the location of the previous definition
>>   make[3]: *** [util/parse-events-bison.o] Error 1
>>
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>> ---
>>  tools/perf/util/Build | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
>> index b6c3f39f081a..28af8e2825b3 100644
>> --- a/tools/perf/util/Build
>> +++ b/tools/perf/util/Build
>> @@ -118,7 +118,7 @@ $(OUTPUT)util/pmu-bison.c: util/pmu.y
>>
>>  CFLAGS_parse-events-flex.o  += -w
>>  CFLAGS_pmu-flex.o           += -w
>> -CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
>> +CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -w
>>  CFLAGS_pmu-bison.o          += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
>>
>>  $(OUTPUT)util/parse-events.o: $(OUTPUT)util/parse-events-flex.c $(OUTPUT)util/parse-events-bison.c
>> --
>> 2.3.5
>>



-- 
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/