linux-kernel - Re: [PATCH 02/10] block: simplify bio_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF1ivSbaoxo5xesrsp8hYVm9b8E6+j8t+jtTdcpfiuVe-yvWWw@mail.gmail.com>
Date:	Tue, 28 Apr 2015 22:42:40 -0700
From:	Ming Lin <mlin@...nel.org>
To:	Christoph Hellwig <hch@....de>
Cc:	lkml <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...nel.dk>,
	Kent Overstreet <kent.overstreet@...il.com>,
	Dongsu Park <dongsu.park@...fitbricks.com>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 02/10] block: simplify bio_add_page()

On Tue, Apr 28, 2015 at 5:12 AM, Christoph Hellwig <hch@....de> wrote:
> On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote:
>> Note that removing call to ->merge_bvec_fn() is fine for
>> bio_add_pc_page(), as SCSI devices usually don't even need that.
>> Few exceptional cases like pscsi or osd are not affected either.
>
> This explanation confuses me.  Based on my reading of the code I'd
> replace it with something like:
>
> Removing the call to ->merge_bvec_fn() is also fine, as no driver that
> implements support for BLOCK_PC commands even has a ->merge_bvec_fn()
> method.

Will update it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/