linux-kernel - Re: [RFC 01/11] mm: debug: format flags in a buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150430153940.GA17156@node.dhcp.inet.fi>
Date:	Thu, 30 Apr 2015 18:39:40 +0300
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-mm@...ck.org
Subject: Re: [RFC 01/11] mm: debug: format flags in a buffer

On Tue, Apr 14, 2015 at 04:56:23PM -0400, Sasha Levin wrote:
> Format various flags to a string buffer rather than printing them. This is
> a helper for later.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>  mm/debug.c |   35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/mm/debug.c b/mm/debug.c
> index 3eb3ac2..c9f7dd7 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -80,6 +80,41 @@ static void dump_flags(unsigned long flags,
>  	pr_cont(")\n");
>  }
>  
> +static char *format_flags(unsigned long flags,
> +			const struct trace_print_flags *names, int count,
> +			char *buf, char *end)
> +{
> +	const char *delim = "";
> +	unsigned long mask;
> +	int i;
> +
> +	buf += snprintf(buf, (buf > end ? 0 : end - buf),
> +				"flags: %#lx(", flags);
> +
> +	/* remove zone id */
> +	flags &= (1UL << NR_PAGEFLAGS) - 1;
> +
> +	for (i = 0; i < count && flags; i++) {
> +                mask = names[i].mask;
> +                if ((flags & mask) != mask)
> +                        continue;
> +
> +                flags &= ~mask;
> +		buf += snprintf(buf, (buf > end ? 0 : end - buf),
> +                		"%s%s", delim, names[i].name);

Indent is off. Otherwise look okay to me.

> +                delim = "|";
> +        }
> +
> +        /* check for left over flags */
> +        if (flags)
> +		buf += snprintf(buf, (buf > end ? 0 : end - buf),
> +                		"%s%#lx", delim, flags);
> +
> +	buf += snprintf(buf, (buf > end ? 0 : end - buf), ")\n");
> +
> +	return buf;
> +}
> +
>  void dump_page_badflags(struct page *page, const char *reason,
>  		unsigned long badflags)
>  {
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/