linux-kernel - Re: [PATCH 2/2] ARM: dts: Fix pinctrl settings for S2MPS11 RTC alarm IRQ on Arndale Octa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hy4l9liav.fsf@deeprootsystems.com>
Date:	Thu, 30 Apr 2015 08:58:16 -0700
From:	Kevin Hilman <khilman@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Sangbeom Kim <sbkim73@...sung.com>,
	linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH 2/2] ARM: dts: Fix pinctrl settings for S2MPS11 RTC alarm IRQ on Arndale Octa

Hi Krzystof,

Krzysztof Kozlowski <k.kozlowski@...sung.com> writes:

> 2015-04-02 23:36 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@...sung.com>:
>> On Arndale Octa the S2MPS11 RTC alarm interrupt was not handled at all
>> because of wrong configuration of interrupt and gpx3-2.
>> 1. Interrupt is signaled by falling edge.
>> 2. This GPIO line is hard-wired on the board to PVDD_APIO_1V8 through a
>>    resistor so pull-up/down must be disabled.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-arndale-octa.dts | 13 ++++++++++++-
>>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> Dear Kukjin,
>
> Any comments  on this and other patches. A lot of emails waits for
> your opinion. Is there anything I could do to help you in smooth
> review or applying?

IMO, I think you you should just start collecting fixes and features and
queuing them for Kukjin and then start working as a co-maintainer.

The samsung platforms have been in a near constant state of breakage
over the last *several* cycles, and something really needs to change in
how these are being monitored and maintained.

If someone else is paying closer attention, especially to important
fixes like this and the recent ones for other imprecies aborts etc.,
all of us who are trying to use these Exynos platforms with mainline
will be in much better shape.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/