linux-kernel - Re: [PATCH 1/1 linux-next] exofs: convert simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2038539261.77713.1430419657241.open-xchange@webmail.nmp.proximus.be>
Date:	Thu, 30 Apr 2015 20:47:37 +0200 (CEST)
From:	Fabian Frederick <fabf@...net.be>
To:	linux-kernel@...r.kernel.org, Boaz Harrosh <ooo@...ctrozaur.com>
Cc:	Benny Halevy <bhalevy@...marydata.com>,
	Alexander Viro <viro@...iv.linux.org.uk>, osd-dev@...n-osd.org,
	adobriyan@...il.com
Subject: Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr



> On 30 April 2015 at 09:55 Boaz Harrosh <ooo@...ctrozaur.com> wrote:
>
>
> On 04/29/2015 08:58 PM, Fabian Frederick wrote:
> > replace obsolete function.
> >
> > Signed-off-by: Fabian Frederick <fabf@...net.be>
>
> Thanks.
> ACK-by: Boaz Harrosh <ooo@...ctrozaur.com>
>
> Are you pushing all these through some tree, or
> You need that I push it? Maybe push all these changes
> through some central place, like Andrew's tree?

Thanks Boaz, I don't use any tree ; I could forward this patch to Andrew but I
guess you
prefer Alexey's solution which uses parse_integer() instead of
match_strlcpy() ?

http://marc.info/?l=linux-kernel&m=143039354303440&w=2

Regards,
Fabian

>
> Boaz
>
> > ---
> > This is untested.
> >
> >  fs/exofs/super.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> > index b795c56..b667f73 100644
> > --- a/fs/exofs/super.c
> > +++ b/fs/exofs/super.c
> > @@ -108,9 +108,14 @@ static int parse_options(char *options, struct
> > exofs_mountopt *opts)
> >                     opts->is_osdname = true;
> >                     break;
> >             case Opt_pid:
> > +           {
> > +                   int rc;
> > +
> >                     if (0 == match_strlcpy(str, &args[0], sizeof(str)))
> >                             return -EINVAL;
> > -                   opts->pid = simple_strtoull(str, NULL, 0);
> > +                   rc = kstrtoull(str, 0, &opts->pid);
> > +                   if (rc)
> > +                           return rc;
> >                     if (opts->pid < EXOFS_MIN_PID) {
> >                             EXOFS_ERR("Partition ID must be >= %u",
> >                                       EXOFS_MIN_PID);
> > @@ -118,6 +123,7 @@ static int parse_options(char *options, struct
> > exofs_mountopt *opts)
> >                     }
> >                     s_pid = 1;
> >                     break;
> > +           }
> >             case Opt_to:
> >                     if (match_int(&args[0], &option))
> >                             return -EINVAL;
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/