linux-kernel - Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150501071631.GA19852@gmail.com>
Date:	Fri, 1 May 2015 09:16:31 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	ast@...mgrid.com, davem@...emloft.net, acme@...nel.org,
	mingo@...hat.com, a.p.zijlstra@...llo.nl,
	masami.hiramatsu.pt@...achi.com, jolsa@...nel.org,
	lizefan@...nel.org, linux-kernel@...r.kernel.org, pi3orama@....com,
	hekuang@...wei.com
Subject: Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to
 load eBPF programs.


* Wang Nan <wangnan0@...wei.com> wrote:

> This series of patches is an approach to integrate eBPF with perf.

Very promising!

> After applying these patches, users are allowed to use following
> command to load eBPF program compiled by LLVM into kernel:
> 
>  $ perf bpf sample_bpf.o

Please keep space for a subcommand space as most other perf 
subcommands do, i.e. make it something like:

    perf bpf add sample_bpf.o

or:

    perf bpf run sample_bpf.o

or:

    perf bpf load sample_bpf.o

So that future subcommands can be added:

    perf bpf list
    perf bpf del <...>
    perf bpf enable <...>
    perf bpf disable <...>
    perf bpf help

and 'perf bpf' should probably display the help page by default, so if 
curious perf users stumble into the new subcommand, they get a basic 
idea about what it's all about.

I.e. you should think about the high level subcommand space right now, 
and pick proper names - because this is going to determine the future 
usability and the success of the tool to a large degree.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/