linux-kernel - Re: [PATCH] net: can: xilinx_can: fix extended frame handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

message-id: <55433753.5050500@pengutronix.de>
Date:	Fri, 1 May 2015 10:20:35 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Jeppe Ledet-Pedersen <jlp@...space.com>, wg@...ndegger.com,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	appana.durga.rao@...inx.com
Cc:	linux-can@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: can: xilinx_can: fix extended frame handling

On 04/29/2015 05:05 PM, Jeppe Ledet-Pedersen wrote:
> Using IDR_SRR in RXFIFO_ID to test for the presence of data is only
> valid for standard frames. For extended frames the bit is always 1 and
> IDR_RTR should be used instead. This patch switches the check to use
> CAN_RTR_FLAG which is correctly set when reading the ID.
> 
> The patch also changes the DW1/DW2 to be read unconditionally, since
> this is necessary to remove the frame from the RXFIFO.
> 
> Signed-off-by: Jeppe Ledet-Pedersen <jlp@...space.com>
> Acked-by: Kedareswara rao Appana <appanad@...inx.com>

Applied to can. Added stable on Cc.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)