linux-kernel - Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11177.1430486761@warthog.procyon.org.uk>
Date:	Fri, 01 May 2015 14:26:01 +0100
From:	David Howells <dhowells@...hat.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	dhowells@...hat.com, rusty@...tcorp.com.au, keyrings@...ux-nfs.org,
	dmitry.kasatkin@...il.com, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]

Michal Marek <mmarek@...e.cz> wrote:

> > +		ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0,
> > +		    "asprintf");
> > +		replace_orig = true;
> > +	}
> > +
> > +	ERR_load_crypto_strings();
> > +	ERR_clear_error();
> 
> The error queue initialization should be done before the first use of
> the ERR() macro. Or the asprintf check should be open-coded, because it
> has nothing to do with openssl.

Good point.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/