| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 May 2015 09:40:04 -0400 From: Paul Gortmaker <paul.gortmaker@...driver.com> To: Herbert Xu <herbert@...dor.apana.org.au> CC: <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH 01/11] drivers/crypto: include <module.h> for modular caam code On 15-04-30 11:24 PM, Herbert Xu wrote: > On Thu, Apr 30, 2015 at 09:47:37PM -0400, Paul Gortmaker wrote: >> This file is built off of a tristate Kconfig option and also contains >> modular function calls so it should explicitly include module.h to >> avoid compile breakage during header shuffles done in the future. >> >> Cc: Herbert Xu <herbert@...dor.apana.org.au> >> Cc: "David S. Miller" <davem@...emloft.net> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> > > Please post patches to linux-crypto@...r.kernel.org if you want them > to go through the crypto tree. Sure, I will add a CC for that in v2 if the patch is needed. > > Also it actually gets module.h through caam/compat.h. So your > patch is unnecessary. Well, in my original build testing this file failed to compile once the modular code was moved from init.h to module.h as per the description in the 0/11. Perhaps since that testing something else has changed. I will drop this patch and retest and if it no longer fails, then great. Thanks, Paul. -- > > Cheers, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists