linux-kernel - Re: context tracking vs. syscall_trace_leave & do_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5543A680.9050106@redhat.com>
Date:	Fri, 01 May 2015 12:14:56 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Andy Lutomirski <luto@...capital.net>
CC:	Fr馘駻ic Weisbecker <fweisbec@...il.com>,
	X86 <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Denys Vlasenko <dvlasenk@...hat.com>
Subject: Re: context tracking vs. syscall_trace_leave & do_notify_resume loop

On 05/01/2015 12:05 PM, Andy Lutomirski wrote:
> On Fri, May 1, 2015 at 9:00 AM, Rik van Riel <riel@...hat.com> wrote:

>> I suspect we probably only need two possible function
>> calls at syscall exit time:
>>
>> 1) A function that is called with interrupts still
>>    enabled, testing flags that could be set again
>>    if something happens (eg. preemption) between
>>    when the function is called, and we return to
>>    user space.
>>
>> 2) A function that is called after the point of
>>    no return, with interrupts disabled, which
>>    does (mostly) small things that only happen
>>    once.
> 
> I think we only need one function.  It would be (asm pseudocode):
> 
> disable irqs;
> if (slow) {
>   save extra regs;
>   call function;
>   restore extra regs;
> }
> 
> return via opportunistic sysret path.
> 
> I can't see any legitimate reason for the current mess, except that
> it's no complicated and so poorly documented that everyone's afraid of
> fixing it.

do_notify_resume() can call do_signal(), which can sleep, after
which all bets are off on what new flags may have been set.

On the other hand, we have stuff that can run just fine with
irqs disabled that we really want to call only once.

For that reason, I suspect we need two functions.

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/