[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150501171656.GC16920@lst.de>
Date: Fri, 1 May 2015 19:16:56 +0200
From: Christoph Hellwig <hch@....de>
To: Shaohua Li <shli@...com>
Cc: linux-kernel@...r.kernel.org, axboe@...com, jmoyer@...hat.com,
hch@....de, neilb@...e.de
Subject: Re: [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request
> - if (use_plug && !blk_queue_nomerges(q) &&
> + if (likely(!is_flush_fua) && !blk_queue_nomerges(q) &&
Please don't sprinkle likely annotations for no go reason. Especially
on metadata write heavy workloads (e.g. an NFS server) it might be very
likely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists