linux-kernel - Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150501180530.GA26281@kroah.com>
Date:	Fri, 1 May 2015 20:05:30 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Simmons, James A." <simmonsja@...l.gov>
Cc:	'Julia Lawall' <Julia.Lawall@...6.fr>,
	Oleg Drokin <oleg.drokin@...el.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"HPDD-discuss@...ts.01.org" <HPDD-discuss@...ts.01.org>
Subject: Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc
 and kfree

On Fri, May 01, 2015 at 05:38:49PM +0000, Simmons, James A. wrote:
> >From: Julia Lawall <Julia.Lawall@...6.fr>
> >
> >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by
> >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree.
> 
> Nak: James Simmons <jsimmons@...radead.org>
> 
> A simple replace will not work. The OBD_ALLOC and OBD_FREE functions allocate memory
> anywhere from one page to 4MB in size.

OBD_FREE() just calls kfree(), it does not allocate any memory, so that
replacement is always ok.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/