linux-kernel - Re: [PATCH v2 01/11] coresight-etm4x: Adding CoreSight ETM4x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1430504936.3928.13.camel@tiscali.nl>
Date:	Fri, 01 May 2015 20:28:56 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, linux-api@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kaixu Xia <kaixu.xia@...aro.org>,
	Chunyan Zhang <zhang.chunyan@...aro.org>
Subject: Re: [PATCH v2 01/11] coresight-etm4x: Adding CoreSight ETM4x driver

Mathieu Poirier schreef op vr 01-05-2015 om 08:39 [-0600]:
> On 30 April 2015 at 15:29, Paul Bolle <pebolle@...cali.nl> wrote:
> > On Wed, 2015-04-29 at 11:16 -0600, Mathieu Poirier wrote:
> >> +#include <linux/module.h>
> >
> > Is this include needed?
> 
> It is needed for "module_param_named()".

I guess that it should suffice to include just
include/linux/moduleparam.h. (Note that [...]/module.h includes
[...]/moduleparam.h.)

> >> +module_amba_driver(etm4x_driver);
> >
> > In a message I sent a short while ago, I suggested that for built-in
> > only code this is equivalent to calling
> >     amba_driver_register(&etm4x_driver);
> >
> > from within a function marked with some sort of *initcall(). Please
> > double check.
> 
> Built-in as a module or not using "module_amba_driver()" deals with
> redundant code.

This is becoming yet another pet peeve: idempotent macros prefixed with
module_. driver_ would be a better prefix. But, in this case,
driver_amba_driver() is silly, amba_driver is used already, and
register_amba_driver() looks like amba_driver_register() way too much.

I fear that this pet peeve is going to hang around my place for quite
some time.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/