linux-kernel - Re: [PATCH] Allow TCP connections to cache SYN packet for userspace inspection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1430512894.3711.140.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 01 May 2015 13:41:34 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Eric B Munson <emunson@...mai.com>
Cc:	Tom Herbert <tom@...bertland.com>,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Allow TCP connections to cache SYN packet for userspace
 inspection

On Fri, 2015-05-01 at 16:29 -0400, Eric B Munson wrote:

>  
> 
> As long as your implementation provides the IP and TCP headers, I would
> be happy with that.  I am also happy to rework my implementation to
> extract and cache information when the request structure is built.  If
> you all have an implementation that you want to post, I will add my ack
> if it meets our needs as well.

Yes, I believe it will be easier we provide our implementation instead
of reviewing yours ;)

For example you had :

+       case TCP_SAVED_SYN:
+               if (!((1 << sk->sk_state) & TCPF_LISTEN))
+                       err = -EINVAL;
+               tp->saved_syn = !!(val);
+               break;


But if you return an error, tp->saved_syn should be left unchanged.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/