linux-kernel - Re: [PATCH] KVM: x86: dump VMCS on invalid entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5544B62D.1010701@redhat.com>
Date:	Sat, 02 May 2015 13:34:05 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Bandan Das <bsd@...hat.com>
CC:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	rkrcmar@...hat.com
Subject: Re: [PATCH] KVM: x86: dump VMCS on invalid entry

On 30/04/2015 20:17, Bandan Das wrote:
>> > Code and format roughly based on Xen's vmcs_dump_vcpu.
> Nice, but isn't it better to keep the output format and behavior the
> same for both dump_vmcb and dump_vmcs() ? why not pr_error ?

I didn't think of looking at dump_vmcb. :)  I knew it existed, but I
didn't remember it's called in these exact circumstances.

The output seems a bit too verbose for pr_error...  Maybe it's worth
changing dump_vmcb instead.  Regarding the output format, some things
could be adjusted to match (especially the segments) but overall the
data is pretty different apart from the segments and a handful of other
fields.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/