linux-kernel - Re: [PATCH] drivers: acpi: make ACPI_PROCFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 02 May 2015 21:09:35 +0800
From:	Hanjun Guo <hanjun.guo@...aro.org>
To:	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
CC:	Lan Tianyu <tianyu.lan@...el.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only

On 2015年05月01日 18:27, Lorenzo Pieralisi wrote:
> The ACPI procfs power interface is initialized by compilation units
> that are only selectable on X86 platforms. Since its usage is
> deprecated and it cannot even be used on platforms other than X86
> it should be compiled in only on X86 platforms.
>
> This patch makes CONFIG_ACPI_PROCFS_POWER dependent on X86, so
> that other architectures are prevented from compiling it in for
> no purpose.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Cc: Hanjun Guo <hanjun.guo@...aro.org>
> Cc: Lan Tianyu <tianyu.lan@...el.com>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>

I think this proc fs was not used for IA64 (it is
for server platform) too.

Acked-by: Hanjun Guo <hanjun.guo@...aro.org>

> ---
> Lan, Rafael,
>
> I do not see any reason why this option is allowed to be selected
> on platforms other than X86, so let's make it X86 only. Please let
> me know what you think, thanks.
>
> Lorenzo
>
>   drivers/acpi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index ab2cbb5..16da185 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -62,7 +62,7 @@ config ACPI_SLEEP
>
>   config ACPI_PROCFS_POWER
>   	bool "Deprecated power /proc/acpi directories"
> -	depends on PROC_FS
> +	depends on X86 && PROC_FS
>   	help
>   	  For backwards compatibility, this option allows
>             deprecated power /proc/acpi/ directories to exist, even when
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/