lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150502183822.GG3007@worktop.Skamania.guest>
Date:	Sat, 2 May 2015 20:38:22 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vikas Shivappa <vikas.shivappa@...ux.intel.com>
Cc:	vikas.shivappa@...el.com, linux-kernel@...r.kernel.org,
	x86@...nel.org, hpa@...or.com, tglx@...utronix.de,
	mingo@...nel.org, tj@...nel.org, matt.fleming@...el.com,
	will.auld@...el.com, peter.zijlstra@...el.com,
	h.peter.anvin@...el.com, kanaka.d.juvva@...el.com
Subject: Re: [PATCH 2/7] x86/intel_rdt: Adds support for Class of service
 management

On Fri, May 01, 2015 at 06:36:36PM -0700, Vikas Shivappa wrote:
> +static inline bool cat_supported(struct cpuinfo_x86 *c)

Is search and replace really that hard?

> +/*
> +* Called with the rdt_group_mutex held.
> +*/

Whitespace damaged and pointless comment.

> +static int rdt_free_closid(struct intel_rdt *ir)
> +{
> +

superfluous whitespace

> +	lockdep_assert_held(&rdt_group_mutex);
> +
> +	WARN_ON(!ccmap[ir->clos].cgrp_count);
> +	ccmap[ir->clos].cgrp_count--;
> +	if (!ccmap[ir->clos].cgrp_count)
> +		clear_bit(ir->clos, rdtss_info.closmap);
> +
> +	return 0;
> +}


These patches really are very sloppy.. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ