linux-kernel - Re: [PATCH 1/3] net: dsa: introduce module_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <402956743.177307.1430593201959.JavaMail.zimbra@savoirfairelinux.com>
Date:	Sat, 2 May 2015 15:00:01 -0400 (EDT)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	David <davem@...emloft.net>, Guenter Roeck <linux@...ck-us.net>,
	Andrew Lunn <andrew@...n.ch>,
	kernel <kernel@...oirfairelinux.com>
Subject: Re: [PATCH 1/3] net: dsa: introduce module_switch_driver macro

Hi all,

>>> This commit introduces a new module_switch_driver macro, similar to
>>> module_platform_driver and such, to reduce boilerplate when declaring
>>> DSA switch drivers.
>>>
>>> In order to use the module_driver macro, register_switch_driver needed
>>> to be changed to return an int instead of void, so make it return 0.
>>
>> Do we get much benefit from having this change, the diffstat looks
>> pretty neutral, ultimately register_switch_driver() might be gone (see:
>> http://www.spinics.net/lists/netdev/msg326900.html) and mv88e6xxx cannot
>> be converted to it due to how it is designed. This is not a strong
>> objection though, the changes look fine to me.
> 
> Indeed, I initially introduce the macro for that purpose, I have an RFC ready
> to remove the mv88e6xxx module and expose its functions, since it'd better be a
> library instead of a driver.
> 
> I'll attach it here as a reply to give an idea of what it looks like and
> get feedback from you.

I messed up with the reply, here's the RFC: https://lkml.org/lkml/2015/5/2/150

Thanks,
-v


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/