linux-kernel - Re: [PATCH 1/1 linux-next] affs: add default case in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55466B79.6090304@nod.at>
Date:	Sun, 03 May 2015 20:39:53 +0200
From:	Richard Weinberger <richard@....at>
To:	Fabian Frederick <fabf@...net.be>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] affs: add default case in switch

Am 03.05.2015 um 20:38 schrieb Fabian Frederick:
> 
> 
>> On 03 May 2015 at 20:23 Richard Weinberger <richard@....at> wrote:
>>
>>
>> Am 03.05.2015 um 20:15 schrieb Fabian Frederick:
>>>> If the code can be reached you need to take a proper action of not the
>>>> warning is bogus.
>>>
>>> As far as I understand, switch in affs_lookup() only updates inode number
>>> when
>>> it's a link so we can simply add default:break to silence gcc warning or
>>> replace
>>> by if().
>>
>> Does the warning trigger with our default set of compiler warnings?
>> Not all gcc warnings are useful. :)
> Only with W=123
> 
>>
>>> affs_iget() switch on the other hand applies to any type of file.
>>> Maybe we could add default: BUG() to avoid working on bad inode ?
>>
>> Or cancel the operation and return -EIO to userspace.
> Ok, thanks, I'll send another version :)

As the warning happens only with W=123 I'd ignore it. :)

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/