linux-kernel - Re: [PATCH v2] fix code style in socklnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 3 May 2015 20:29:33 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Kai Katsumata <imperialroyalguard38@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fix code style in socklnd_proto.c

On Mon, Apr 06, 2015 at 11:21:33PM +0900, Kai Katsumata wrote:
> fix coding style by ./scripts/checkpatch.pl.
> fix 80 charracters limit, space prohibited between function name and
> open parenthesis '('
> and  braces {} are not necessary for single statement blocks.

That's two different things, so this should be two different patches.
Each patch should only do one logical thing.

> 
> Before patch is html format. But this is plain text format.
> Before patch is From: line didn't match the Signed-off-by line. Align
> the these lines.

This paragraph doesn't need to be here, please put it below the --- line
so it doesn't show up in the changelog.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/