linux-kernel - Re: [PATCH 4.0 219/220] netfilter: x_tables: fix cgroup matching on non-full sks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 May 2015 20:42:25 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Stefan Lippers-Hollmann <s.l-h@....de>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Alexey Perevalov <a.perevalov@...sung.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Thomas Backlund <tmb@...eia.org>
Subject: Re: [PATCH 4.0 219/220] netfilter: x_tables: fix cgroup matching on
 non-full sks

On Sun, May 03, 2015 at 12:11:30AM +0200, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On 2015-05-02, Greg Kroah-Hartman wrote:
> > 4.0-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Daniel Borkmann <daniel@...earbox.net>
> > 
> > commit afb7718016fcb0370ac29a83b2839c78b76c2960 upstream.
> > 
> > While originally only being intended for outgoing traffic, commit
> > a00e76349f35 ("netfilter: x_tables: allow to use cgroup match for
> > LOCAL_IN nf hooks") enabled xt_cgroups for the NF_INET_LOCAL_IN hook
> > as well, in order to allow for nfacct accounting.
> > 
> > Besides being currently limited to early demuxes only, commit
> > a00e76349f35 forgot to add a check if we deal with full sockets,
> > i.e. in this case not with time wait sockets. TCP time wait sockets
> > do not have the same memory layout as full sockets, a lower memory
> > footprint and consequently also don't have a sk_classid member;
> > probing for sk_classid member there could potentially lead to a
> > crash.
> 
> This introduces the same build failure into queue-4.0, as previously 
> reported by Thomas Backlund for queue-3.19 in 
> 
> 	http://lkml.kernel.org/r/<554545E5.8020606@...eia.org>
> 
> /tmp/buildd/linux-aptosid-4.0/net/netfilter/xt_cgroup.c: In function 'cgroup_mt':
> /tmp/buildd/linux-aptosid-4.0/net/netfilter/xt_cgroup.c:42:2: error: implicit declaration of function 'sk_fullsock' [-Werror=implicit-function-declaration]
>   if (skb->sk == NULL || !sk_fullsock(skb->sk))
>   ^
> cc1: some warnings being treated as errors
> /tmp/buildd/linux-aptosid-4.0/scripts/Makefile.build:264: recipe for target 'net/netfilter/xt_cgroup.o' failed
> make[7]: *** [net/netfilter/xt_cgroup.o] Error 1
> 
> Regards
> 	Stefan Lippers-Hollmann

Thanks, now removed.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/