linux-kernel - Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 03 May 2015 22:33:43 +0300
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Arnd Bergmann <arnd@...db.de>, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

Hi Nicholas,

Thank you for the patch.

On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote:
> shdma_tx_submit() called via dmaengine_submit() returns the assigned
> cookie but this is not used here so the variable and assignment can
> be dropped.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

I would rephrase the commit message to avoid mentioning shdma_tx_submit() as 
that's not relevant. Something like "dmaengine_submit() returns the assigned
cookie but this is not used here so the variable and assignment can be 
dropped."

With that fixed,

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> 
> V2: As pointed out by Laurent Pinchart <laurent.pinchart@...asonboard.com>
>     the variable and assignment can be dropped but not the call to
>     dmaengine_submit(desc) - fixed up
> 
> Patch was compile tested with ap325rxa_defconfig (implies
> CONFIG_MTD_NAND_SH_FLCTL=y)
> 
> Patch is against 4.1-rc1 (localversion-next is -next-20150501)
> 
>  drivers/mtd/nand/sh_flctl.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
> index 9b032dd..d1c46e5 100644
> --- a/drivers/mtd/nand/sh_flctl.c
> +++ b/drivers/mtd/nand/sh_flctl.c
> @@ -351,7 +351,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl
> *flctl, unsigned long *buf, struct dma_chan *chan;
>  	enum dma_transfer_direction tr_dir;
>  	dma_addr_t dma_addr;
> -	dma_cookie_t cookie = -EINVAL;
>  	uint32_t reg;
>  	int ret = 0;
>  	unsigned long time_left;
> @@ -377,7 +376,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl
> *flctl, unsigned long *buf,
> 
>  		desc->callback = flctl_dma_complete;
>  		desc->callback_param = flctl;
> -		cookie = dmaengine_submit(desc);
> +		dmaengine_submit(desc);
> 
>  		dma_async_issue_pending(chan);
>  	} else {

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/