linux-kernel - Re: [PATCH 1/3] Add patman patch automation script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPnjgZ1biHpCyWvSH4eKZkduhs54SXTtaRbFJva7QWMLma4MBw@mail.gmail.com>
Date:	Sun, 3 May 2015 15:43:55 -0600
From:	Simon Glass <sjg@...omium.org>
To:	Richard Weinberger <richard@....at>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH 1/3] Add patman patch automation script

Hi Richard,

On 3 May 2015 at 14:43, Richard Weinberger <richard@....at> wrote:
> Am 03.05.2015 um 22:40 schrieb Simon Glass:
>>> But I don't think it makes much sense to carry it with the Linux kernel tree.
>>> Other projects can also use it and it does not seem to be very Linux kernel
>>> specific.
>>> git, quilt and other great tools also have their own repositories.
>>
>> My reasoning is that:
>>
>> - more will find it / use it if it is in-tree
>> - it avoids installation and old-version problems (e.g. I suppose this
>> is why the device tree compiler is built-in)
>> - it is somewhat Linux-specific (e.g. uses get_maintainers,
>> checkpatch.pl) and can break if checkpatch.pl if the wrong version
>> (e.g. you check out and send patches from an older tree)
>> - it could be built into the Linux workflow [1] and might thereby
>> reduce the amount of confusion and errors (did you run checkpatch?,
>> your change log is in the wrong place, you forgot to add your
>> sign-off, etc.)
>
> If we'd follow these arguments we'd have to move the whole GNU into the
> kernel tree. ;-)

Well maybe the first two.

> checkpatch.pl and get_maintainers.pl are not really a show-stopper.
> Other projects are using them too. You can make them also configurable.
> i.e. check_script and get_maintaner_script.

Understood, I'm just explaining my reasoning for sending this patch.
With U-Boot it has been very convenient to be able to rely on this
being available in the tree. 3000 lines is a drop in the ocean with
Linux's 22m lines.

But I fully understand your point of view. If nothing else, at least
this series provides an easy way for people to try it out.

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/