linux-kernel - Re: [PATCH 1/2] rtc: interface: Fix coding style violations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 3 May 2015 18:42:26 +0900
From:	Krzysztof Kozłowski <k.kozlowski.k@...il.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rtc: interface: Fix coding style violations

2015-05-03 18:39 GMT+09:00 Alexandre Belloni
<alexandre.belloni@...e-electrons.com>:
> Hi,
>
> On 23/04/2015 at 21:25:39 +0900, Krzysztof Kozlowski wrote :
>> Fix issues reported by checkpatch:
>>   ERROR: open brace '{' following struct go on the same line
>>   ERROR: "foo* bar" should be "foo *bar"
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@...il.com>
>> ---
>>  include/linux/rtc.h | 9 ++++-----
>>  1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/linux/rtc.h b/include/linux/rtc.h
>> index c8b68741994e..85b48b29a143 100644
>> --- a/include/linux/rtc.h
>> +++ b/include/linux/rtc.h
>> @@ -101,8 +101,7 @@ struct rtc_timer {
>>  /* flags */
>>  #define RTC_DEV_BUSY 0
>>
>> -struct rtc_device
>> -{
>> +struct rtc_device {
>>       struct device dev;
>>       struct module *owner;
>>
>> @@ -202,10 +201,10 @@ int rtc_register(rtc_task_t *task);
>>  int rtc_unregister(rtc_task_t *task);
>>  int rtc_control(rtc_task_t *t, unsigned int cmd, unsigned long arg);
>>
>> -void rtc_timer_init(struct rtc_timer *timer, void (*f)(void* p), void* data);
>> -int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer* timer,
>> +void rtc_timer_init(struct rtc_timer *timer, void (*f)(void *p), void *data);
>> +int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer *timer,
>>                       ktime_t expires, ktime_t period);
>
> While at it, alignment here should match the open parenthesis.

Sure, I'll respin.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/