linux-kernel - Re: [PATCH 1/1 linux-next] affs: add default case in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 May 2015 16:51:41 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] affs: add default case in switch

On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick <fabf@...net.be> wrote:
> Fix gcc -Wswitch-default warnings
>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  fs/affs/inode.c | 2 ++
>  fs/affs/namei.c | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/fs/affs/inode.c b/fs/affs/inode.c
> index 1734950..623398e 100644
> --- a/fs/affs/inode.c
> +++ b/fs/affs/inode.c
> @@ -143,6 +143,8 @@ struct inode *affs_iget(struct super_block *sb, unsigned long ino)
>                 inode->i_op = &affs_symlink_inode_operations;
>                 inode->i_data.a_ops = &affs_symlink_aops;
>                 break;
> +       default:
> +               break;
>         }
>
>         inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec
> diff --git a/fs/affs/namei.c b/fs/affs/namei.c
> index 181e05b..517926d 100644
> --- a/fs/affs/namei.c
> +++ b/fs/affs/namei.c
> @@ -237,6 +237,9 @@ affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
>                 //case ST_LINKDIR:
>                 case ST_LINKFILE:
>                         ino = be32_to_cpu(AFFS_TAIL(sb, bh)->original);
> +                       break;
> +               default:
> +                       break;

How can this code path be reached?
If I read your patch correctly it just silences gcc.

If the code can be reached you need to take a proper action of not the
warning is bogus.

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/