linux-kernel - Re: [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55463F2F.2050505@linux.intel.com>
Date:	Sun, 03 May 2015 23:30:55 +0800
From:	"Fu, Zhonghui" <zhonghui.fu@...ux.intel.com>
To:	Arend van Spriel <arend@...adcom.com>
CC:	"brudley@...adcom.com" <brudley@...adcom.com>,
	Franky Lin <frankyl@...adcom.com>,
	"meuleman@...adcom.com" <meuleman@...adcom.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	"pieterpg@...adcom.com" <pieterpg@...adcom.com>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"brcm80211-dev-list@...adcom.com" <brcm80211-dev-list@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac
 driver



On 2015/4/27 16:59, Arend van Spriel wrote:
> On 04/27/15 07:00, Fu, Zhonghui wrote:
>> ACPI will manage WiFi chip's power state during suspend/resume
>> process on some tablet platforms(such as ASUS T100TA). This is
>> not supported by brcmfmac driver now, and the context of WiFi
>> chip will be damaged after resume. This patch disconnects the
>> relationship between WiFi chip and it's ACPI companion, and
>> prohibit ACPI PM for it.
>
> Nice. However, ACPI may contain configuration data that brcmfmac needs on some platforms and Adrian Hunter is looking into this. So it is probably better to do this operation at the end of the probe before returning successful.
Your comment is right. I introduced another implementation in new patch - "[PATCH v2] brcmfmac: prohibit ACPI power management for brcmfmac driver".


Thanks,
Zhonghui
>
> Regards,
> Arend
>
>> Signed-off-by: Zhonghui Fu<zhonghui.fu@...ux.intel.com>
>> ---
>>   drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/