linux-kernel - Re: [PATCH 0/3 v2] Replace OBD_CPT_ALLOC etc by kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 3 May 2015 16:15:23 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<kernel-janitors@...r.kernel.org>" <kernel-janitors@...r.kernel.org>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<HPDD-discuss@...ts.01.org>" <HPDD-discuss@...ts.01.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>
Subject: Re: [PATCH 0/3 v2] Replace OBD_CPT_ALLOC etc by kzalloc_node

All three are good from my perspective.
Thanks!

On May 3, 2015, at 10:07 AM, Julia Lawall wrote:

> The complete semantic patch used to make this transformation is as follows:
> (http://coccinelle.lip6.fr/).
> 
> // <smpl>
> @@
> expression ptr,cptab,cpt,size,gfp;
> @@
> 
> - OBD_CPT_ALLOC_GFP(ptr, cptab, cpt, size, gfp)
> + ptr = kzalloc_node(size, gfp, cfs_cpt_spread_node(cptab, cpt))
> 
> @@
> expression ptr,cptab,cpt,size;
> @@
> 
> - OBD_CPT_ALLOC(ptr, cptab, cpt, size)
> + ptr = kzalloc_node(size, GFP_NOFS, cfs_cpt_spread_node(cptab, cpt))
> 
> @@
> expression ptr,cptab,cpt;
> @@
> 
> - OBD_CPT_ALLOC_PTR(ptr, cptab, cpt)
> + ptr = kzalloc_node(sizeof(*ptr), GFP_NOFS, cfs_cpt_spread_node(cptab,cpt))
> // </smpl>
> 
> Note that the previously proposed patch "Add obd_cpt_alloc function" is not
> needed, as the transformation is done without adding a new function.
> 
> These patches should be applied after the patches with subjects "Use
> kzalloc and kfree" and "remove unneeded null test before free".
> 
> v2 makes the subject lines more uniform.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/