linux-kernel - Re: [PATCH 3.10 00/65] 3.10.77-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 May 2015 10:09:14 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, shuah.kh@...sung.com,
	stable <stable@...r.kernel.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Rabin Vincent <rabin@....in>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3.10 00/65] 3.10.77-stable review

On Sun, May 03, 2015 at 09:40:11PM -0700, Guenter Roeck wrote:
> On 05/03/2015 12:49 PM, Guenter Roeck wrote:
> >On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote:
> >>This is the start of the stable review cycle for the 3.10.77 release.
> >>There are 65 patches in this series, all will be posted as a response
> >>to this one.  If anyone has any issues with these being applied, please
> >>let me know.
> >>
> >>Responses should be made by Mon May  4 19:00:04 UTC 2015.
> >>Anything received after that time might be too late.
> >>
> Also, for s390, similar to the error seen in 3.14:
> 
> arch/s390/kernel/suspend.c: In function 'pfn_is_nosave':
> arch/s390/kernel/suspend.c:141:30: error: '_eshared' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:141:30: note: each undeclared identifier is reported only once for each function it appears in
> arch/s390/kernel/suspend.c:142:28: error: '_stext' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:151:10: error: 'ipl_info' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:151:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function)
> 
> Presumably for the same reason ('s390/hibernate: fix save and restore of kernel text section').

Oh, crap.. for 3.10 two includes are missing within arch/s390/kernel/suspend.c:
<asm/ipl.h> and <asm/sections.h>

The corresponding commits are:
ipl.h:
77e844b9644026c11c5883144540155de39af767
"s390/hibernate: add early resume function"
(applies cleanly to 3.10, and was merged with 3.12)

sections.h
7f8998c7aef3ac9c5f3f2943e083dfa6302e90d0
"nosave: consolidate __nosave_{begin,end} in <asm/sections.h>"

This one is ugly, since it touches a lot of architectures and depends on a
lot of other unrelated patches. I'd say it's easier to add an extra patch that
simply adds the missing include, hm? (or add the include to the patch)
The same as true for the build failure on 3.14, unfortunately.

Does that make sense?

Guenther, thank you for reporting and testing!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/