linux-kernel - Re: [PATCH 5/6] x86: replace cpu_**_mask() with topology_**

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 May 2015 10:23:06 +0200
From:	Bartosz Golaszewski <bgolaszewski@...libre.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.de>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Benoit Cousson <bcousson@...libre.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 5/6] x86: replace cpu_**_mask() with topology_**_cpumask()

2015-05-02 8:33 GMT+02:00 Ingo Molnar <mingo@...nel.org>:
>
> * Bartosz Golaszewski <bgolaszewski@...libre.com> wrote:
>
>> The former duplicate the functionalities of the latter but are neither
>> documented nor arch-independent.
>
>>       if (!has_mp) {
>> -             cpumask_set_cpu(cpu, cpu_sibling_mask(cpu));
>> +             cpumask_set_cpu(cpu, topology_thread_cpumask(cpu));
>>               cpumask_set_cpu(cpu, cpu_llc_shared_mask(cpu));
>
> So why does topology.h invent a new name for 'sibling CPUs'?
>
> At least in the scheduling context, 'sibling' is the term we are using
> in most places in the scheduler - try 'git grep sibling kernel/sched/'.
>
> 'thread' is a bad name anyway for a CPU, even if we didn't have an
> existing term for it.

Actually those macros used to be called topology_core_siblings() and
topology_thread_siblings() until commit fbd59a8d1.

> So please rename topology_thread_cpumask to topology_sibling_cpumask
> to not replace one inconsistency for another one ...

I'll prepare a new series.

Best regards,
Bartosz Golaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/