lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 May 2015 12:34:51 +0100 From: Daniel Stone <daniel@...ishbar.org> To: Inki Dae <inki.dae@...sung.com> Cc: Krzysztof Kozlowski <k.kozlowski.k@...il.com>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, Seung-Woo Kim <sw0312.kim@...sung.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org>, Kyungmin Park <kyungmin.park@...sung.com>, Kukjin Kim <kgene@...nel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD Hi, On 4 May 2015 at 08:43, Inki Dae <inki.dae@...sung.com> wrote: > On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >> error: > > No, eDP has no any dependency of FIMD but DECON. Just add dependency > code like below, > > config DRM_EXYNOS7_DECON > bool "Exynos DRM DECON" > - depends on DRM_EXYNOS > + depends on DRM_EXYNOS && !FB_S3C But it does clearly and explicitly call fimd_dp_clock_enable from exynos_dp_powero{n,ff}. So the dependency you're proposing seems backwards: it's not an expression of the requirements of the current code (that FIMD DP code be available, i.e. CONFIG_DRM_EXYNOS_FIMD is selected), but an indirect expression of another dependency (CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD, so disable CONFIG_FB_S3C). Additionally, as the call comes from exynos_dp_core.c, which is built by CONFIG_DRM_EXYNOS_DP (an explicitly user-selectable option), why shouldn't the dependency be there? Ah, because the dependency on DP is for (DECON || FIMD), but as DECON doesn't provide fimd_dp_clock_enable(), it doesn't seem like it would compile if you selected DECON and not FIMD. So, for me, the cleanest solution would be config DRM_EXYNOS_DP gains a hard dependency on DRM_EXYNOS_FIMD, at least until it can be fixed to compile without FIMD. Cheers, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists