linux-kernel - Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150504114558.GD15510@sirena.org.uk>
Date:	Mon, 4 May 2015 12:45:58 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kevin Cernekee <cernekee@...omium.org>
Cc:	lgirdwood@...il.com, lars@...afoo.de, dgreid@...omium.org,
	abrestic@...omium.org, olofj@...omium.org,
	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power
 amplifiers

On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote:

> +	}
> +
> +	codec->dapm.bias_level = level;
> +	return 0;
> +}

This assignment was factored out into the core last week, I'll fix up
for that.

> +	if (dev->of_node) {
> +		const struct of_device_id *of_id;
> +
> +		of_id = of_match_device(tas571x_of_match, dev);
> +		if (of_id)
> +			priv->chip = of_id->data;
> +	}

Doesn't of_match_device() do the right thing with devices not registered
from DT?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)